Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: license warning text changes. #24264

Merged
merged 3 commits into from
Nov 23, 2024
Merged

rpk: license warning text changes. #24264

merged 3 commits into from
Nov 23, 2024

Conversation

r-vasquez
Copy link
Contributor

This PR adds a new warning message for expired enterprise licenses and modifies existing ones to display the days left until the license expires.

Examples:

Note: your TRIAL license will expire in 9 days. To request a license, please visit https://redpanda.com/upgrade.
To try Redpanda Enterprise for 30 days, visit https://redpanda.com/try-enterprise. For more information, see
https://docs.redpanda.com/current/get-started/licenses/#redpanda-enterprise-edition

LICENSE INFORMATION
===================
License status:     valid
License violation:  false
Organization:       Devex
Type:               free_trial
Expires:            Dec 2 2024

$ rpk cluster health

WARNING: your ENTERPRISE license has expired. The following Enterprise features are being used in
your Redpanda cluster: [partition_auto_balancing_continuous]. These features require a license.
To request a new license, please visit https://support.redpanda.com. For more information, see
https://docs.redpanda.com/current/get-started/licenses/#redpanda-enterprise-edition

CLUSTER HEALTH OVERVIEW
=======================
Healthy:                          true
Unhealthy reasons:                []
Controller ID:                    0
All nodes:                        [0]
Nodes down:                       []
Leaderless partitions (0):        []
Under-replicated partitions (0):  []

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@r-vasquez
rpk: modify CTA in license warning
35900aa 
This also adds a new warning case, for
enterprise license which have expired.
@r-vasquez
rpk: add CTA to rpk cluster license info
1c358a7
@r-vasquez
rpk: avoid repeating warning for trial licenses
45d48d5 
When the license is a trial license and the cluster
has enterprise features enabled, rpk already
prints a warning when creating the admin API client

We avoid printing another warning in this command
as this can be repetitive.
@r-vasquez r-vasquez force-pushed the warning-text-changes branch from f224aec to 45d48d5 Compare November 22, 2024 20:18
@mattschumpert
Copy link

lgtm

@r-vasquez
Copy link
Contributor Author

Unrelated build-bazel error in https://buildkite.com/redpanda/redpanda/builds/58613#019355f3-cb20-47d4-aec7-b2b3fa1203a8

Is being fixed in 3431bfb

@twmb twmb merged commit 159c35b into redpanda-data:dev Nov 23, 2024
19 of 22 checks passed
@twmb twmb deleted the warning-text-changes branch November 23, 2024 01:46
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Nov 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twmb twmb twmb approved these changes

@mattschumpert mattschumpert Awaiting requested review from mattschumpert

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/build area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-vasquez @mattschumpert @vbotbuildovich @twmb